Bump tested pg versions in preparation of pg14
What does this MR do and why?
Curious to see how hard it was to switch from pg12 to pg13 for testing defaults. Just changes the pipeline to use updated versions in preparation for the upgrade to gitlab.com and the omnibus updates in early 16.x
- Adds pg14 nightly jobs
- Moves pg12 to nightly
- Makes pg13 default
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @alexives
added 1 commit
- b1e04f92 - Bump tested pg versions in preparation of pg14
added 573 commits
-
b1e04f92...ccc3a087 - 572 commits from branch
master
- ab3af89a - Bump tested pg versions in preparation of pg14
-
b1e04f92...ccc3a087 - 572 commits from branch
- A deleted user
added documentation frontend labels
2 Warnings This merge request is quite big (896 lines changed), please consider splitting it into multiple merge requests. 95f45660: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/development/pipelines/index.md
(Link to current live version) -
doc/development/pipelines/internals.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Hinam Mehra (
@hmehra
) (UTC+11, 16 hours ahead of@alexives
)Allen Cook (
@acook.gitlab
) (UTC-4, 1 hour ahead of@alexives
)frontend Tomáš Bulva (
@tbulva
) (UTC+2, 7 hours ahead of@alexives
)Justin Ho (
@justin_ho
) (UTC+7, 12 hours ahead of@alexives
)maintenanceworkflow / maintenancepipelines for CI, Danger Raimund Hook (
@stingrayza
) (UTC+1, 6 hours ahead of@alexives
)Rémy Coutable (
@rymai
) (UTC+2, 7 hours ahead of@alexives
)Engineering Productivity Reviewer review is optional for Engineering Productivity Ash McKenzie (
@ashmckenzie
) (UTC+11, 16 hours ahead of@alexives
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
added 1 commit
- 1e1561f3 - Bump tested pg versions in preparation of pg14
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 796c3834expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Govern | 26 | 0 | 5 | 0 | 31 | ✅ | | Verify | 12 | 0 | 0 | 2 | 12 | ❗ | | Manage | 12 | 0 | 3 | 1 | 15 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 162 | 0 | 12 | 3 | 174 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 796c3834expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 786 | 4 | 37 | 271 | 827 | ❌ | | Plan | 302 | 0 | 0 | 89 | 302 | ❗ | | Package | 144 | 0 | 40 | 80 | 184 | ❗ | | Data Stores | 181 | 0 | 3 | 43 | 184 | ❗ | | Verify | 247 | 0 | 45 | 182 | 292 | ❗ | | Fulfillment | 11 | 0 | 106 | 2 | 117 | ❗ | | Manage | 210 | 0 | 16 | 81 | 226 | ❗ | | Govern | 230 | 0 | 0 | 155 | 230 | ❗ | | Framework sanity | 0 | 0 | 6 | 0 | 6 | ➖ | | Secure | 29 | 0 | 21 | 22 | 50 | ❗ | | Release | 30 | 0 | 0 | 16 | 30 | ❗ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Analytics | 11 | 0 | 0 | 7 | 11 | ❗ | | Monitor | 52 | 1 | 0 | 39 | 53 | ❌ | | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2255 | 5 | 305 | 987 | 2565 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
Setting label(s) ~"devops::data_stores" based on groupdatabase.
- Resolved by Alex Ives
Needs gitlab-build-images!659 (merged) before this'll work.
changed milestone to %15.10
added 1 commit
- 83533468 - Bump tested pg versions in preparation of pg14
- A deleted user
added backend label
Setting label(s) ~"devops::data_stores" based on groupdatabase.
Setting label(s) devopsdata stores based on groupdatabase.
added devopsdata stores label
added 794 commits
-
83533468...945de09e - 793 commits from branch
master
- 4338f101 - Bump tested pg versions in preparation of pg14
-
83533468...945de09e - 793 commits from branch
changed milestone to %15.11
- Resolved by Alex Ives
@twk3 - I tried to get this started last week after we talked but didn't manage to get it all working. I think I must have something wrong with the foss pipelines, but I'm not sure what I'm missing. Is there someone from your team familiar enough to take a quick look and point us in the right direction? Alternately if you have someone already doing this I'm happy to close this out. I'm reasonably certain everything is working okay, though there is one spec that seems to be returning a string instead of a number, not sure if that's related to the change though.
added 211 commits
-
4338f101...92b85f42 - 210 commits from branch
master
- 8713b704 - Bump tested pg versions in preparation of pg14
-
4338f101...92b85f42 - 210 commits from branch
added 1 commit
- 7d5dc236 - Bump tested pg versions in preparation of pg14
added 1 commit
- a776ac07 - Explicitly cast value to number in grape api
- Resolved by Adam Hegyi
mentioned in issue #398211 (closed)
assigned to @l.rosa
- Resolved by Leonardo da Rosa
@l.rosa would you mind taking a look at the failures here to try and get this over the finish line? I kept thinking this would be quick and easy to do on the side, but it's not going as smoothly as that. I'd say we should feel free to err on the side of quick fixes to get specs passing and then we can address root causes in follow ups.
added 531 commits
-
7d5dc236...312d9f78 - 530 commits from branch
master
- 4fad901f - Bump tested pg versions in preparation of pg14
-
7d5dc236...312d9f78 - 530 commits from branch
Database migrations (on the main database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change No histogram available for visualization
Background migrations
Other migrations pending on GitLab.com
Migration Type Total runtime Result DB size change 20230303232426 - AddRoleApproversToScanResultPolicies Regular 2.2 s +0.00 B 20230301020246 - EnsureMrUserMentionsNoteIdBigintBackfillIsFinishedForGitlabDotCom Post deploy 2.4 s +0.00 B 20230301020356 - SwapMergeRequestUserMentionsNoteIdToBigint Post deploy 567.9 s -1.34 GiB 20230309085547 - PrepareCiBuildsConstraintsForListPartitioning Post deploy 2.5 s +8.00 KiB 20230310213308 - SyncSecurityPolicyRuleSchedulesThatMayHaveBeenDeletedByABug Post deploy 2.2 s +0.00 B 20230315161408 - FinalizeSetNotificationsBigintConversionBackfill Post deploy 1.5 s +0.00 B 20230316114426 - SwapCiRunnerMachineBuildsPrimaryKey Post deploy 2.1 s +0.00 B 20230317195228 - PrepareAsyncSentNotificationsIndex Post deploy 1.9 s +0.00 B 20230320155635 - AddIndexToNamespaceDetails Post deploy 255.3 s +1008.59 MiB 20230321011529 - EnsureVumBigintBackfillIsFinishedForGlDotCom Post deploy 2.1 s +0.00 B 20230321011903 - SwapVulnerabilityUserMentionsNoteIdToBigintForGitlabDotCom Post deploy 4.5 s +0.00 B 20230321024333 - EnsureDesignUserMentionsNoteIdBigintBackfillIsFinishedForGitlabDotCom Post deploy 1.5 s +0.00 B 20230321024903 - SwapDesignUserMentionsNoteIdToBigintForGitlabDotCom Post deploy 65.9 s -1.50 MiB 20230321124837 - RemoveCiBuildsPartitionIdDefault Post deploy 1.8 s +0.00 B Clone Details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-1809712-9569229-main
2023-03-22T17:07:22Z 2023-03-22T12:40:08Z 2023-03-23 05:27:33 +0000 database-testing-1809712-9569229-ci
2023-03-22T17:07:22Z 2023-03-22T16:45:57Z 2023-03-23 05:27:33 +0000 Artifacts
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
Database migrations (on the ci database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change No histogram available for visualization
Background migrations
Other migrations pending on GitLab.com
Migration Type Total runtime Result DB size change 20230303232426 - AddRoleApproversToScanResultPolicies Regular 2.8 s +0.00 B 20230301020246 - EnsureMrUserMentionsNoteIdBigintBackfillIsFinishedForGitlabDotCom Post deploy 2.0 s +0.00 B 20230301020356 - SwapMergeRequestUserMentionsNoteIdToBigint Post deploy 5.0 s -8.00 KiB 20230309085547 - PrepareCiBuildsConstraintsForListPartitioning Post deploy 2.8 s +8.00 KiB 20230310213308 - SyncSecurityPolicyRuleSchedulesThatMayHaveBeenDeletedByABug Post deploy 1.9 s +0.00 B 20230315161408 - FinalizeSetNotificationsBigintConversionBackfill Post deploy 2.0 s +0.00 B 20230316114426 - SwapCiRunnerMachineBuildsPrimaryKey Post deploy 2.4 s -1.01 GiB 20230317195228 - PrepareAsyncSentNotificationsIndex Post deploy 2.3 s +0.00 B 20230320155635 - AddIndexToNamespaceDetails Post deploy 2.4 s +8.00 KiB 20230321011529 - EnsureVumBigintBackfillIsFinishedForGlDotCom Post deploy 1.9 s +0.00 B 20230321011903 - SwapVulnerabilityUserMentionsNoteIdToBigintForGitlabDotCom Post deploy 5.4 s +0.00 B 20230321024333 - EnsureDesignUserMentionsNoteIdBigintBackfillIsFinishedForGitlabDotCom Post deploy 2.0 s +0.00 B 20230321024903 - SwapDesignUserMentionsNoteIdToBigintForGitlabDotCom Post deploy 4.3 s +0.00 B 20230321124837 - RemoveCiBuildsPartitionIdDefault Post deploy 2.2 s +0.00 B Clone Details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-1809712-9569229-main
2023-03-22T17:07:22Z 2023-03-22T12:40:08Z 2023-03-23 05:27:33 +0000 database-testing-1809712-9569229-ci
2023-03-22T17:07:22Z 2023-03-22T16:45:57Z 2023-03-23 05:27:33 +0000 Artifacts
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
- A deleted user
added database-testing-automation label
mentioned in issue #398772 (closed)
requested review from @maddievn
@maddievn can I have your maintenanceworkflow / maintenancepipelines review?
- Resolved by Achilleas Pipinellis
@axil can I have your review on the doc changes?
requested review from @axil
removed frontend label
added 112 commits
-
c14728d0...0e879c08 - 110 commits from branch
master
- 54cca459 - Bump tested pg versions in preparation of pg14
- 4e6b5644 - Cast duration as double precision
-
c14728d0...0e879c08 - 110 commits from branch
- A deleted user
added frontend label
- Resolved by Leonardo da Rosa
- Resolved by Leonardo da Rosa
added Technical Writing development guidelines twfinished labels
removed review request for @axil
@axil
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by John Mason
requested review from @a_luna
It seems that this job is failing because the license key has expired or is invalid
Edited by Leonardo da Rosarequested review from @john-mason and removed review request for @a_luna
- Resolved by John Mason
- Resolved by Jennifer Li
@l.rosa looks like we need one more approval from Engineering Productivity before we can set MWPS
requested review from @jennli
added 312 commits
-
22236059...7886bcae - 308 commits from branch
master
- 671ea7ea - Bump tested pg versions in preparation of pg14
- 9a8161bb - Cast duration as double precision
- 24be3eaf - Check PG14 compatibility with ES8
- b40e3ed3 - Undo change in comment
Toggle commit list-
22236059...7886bcae - 308 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 188 commits
-
b40e3ed3...20ac9665 - 184 commits from branch
master
- 95f45660 - Bump tested pg versions in preparation of pg14
- b2512109 - Cast duration as double precision
- e9c9c5be - Check PG14 compatibility with ES8
- 7efd8b3b - Undo change in comment
Toggle commit list-
b40e3ed3...20ac9665 - 184 commits from branch
mentioned in issue omnibus-gitlab#7396 (closed)
@jennli, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit ce2fcceb
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #402982 (closed)
@mtan-gitlab please note that the JH pipeline is currently broken likely due to this change. I didn't realize that this would impact the JH pipeline so I didn't ping you ahead of time, sorry about that
Edited by Jennifer Li@mtan-gitlab the action needed to fix the yaml syntax error is to update these dependency job names by replacing pg12 with pg13.
Thanks @jennli, yes, renaming the jobs with pg13 should work https://jihulab.com/gitlab-cn/gitlab/-/merge_requests/1510.
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added docsimprovement tw-weight1 labels
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !123711 (merged)
mentioned in merge request !123420 (merged)
mentioned in issue gitlab-com/gl-infra/production#16247 (closed)
added groupdatabase frameworks label and removed groupdatabase [DEPRECATED] label