Draft: Resolve "Fix gitlab agent isVersionOutdated to handle KAS release candidate versions"
requested to merge 389832-fix-gitlab-agent-isversionoutdated-to-handle-kas-release-candidate-versions into master
What does this MR do and why?
The agent version may be in the format of vX.Y.Z-rcN
whereas the -rcN
is not really required for the version comparison.
I suppose it's not 100% correct to actually leave it out of the comparison, on the other hand it's most likely not worth the complexity. I suggest that if we want anything more complex than what we have right now, we should consume a library to actually handle this version parsing and comparison.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #389832 (closed)
Edited by Timo Furrer