Fix analytics charts not filling to fit panel containers
What does this MR do and why?
Fixes an issue where analytics visualisations that uses GlChart
would not grow to fit the panel's height.
Dependant on another GitLab MR being merged first Update dependency @gitlab/ui to v56.4.0 (!114501 - merged) which adds gitlab-ui@dab39d81.
Resolves Update chart visualization to fill the panel co... (#393355 - closed).
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
To test the product analytics dashboard items are shown, you will need to follow the instructions at https://gitlab.com/gitlab-org/gitlab/-/snippets/2474959 to enable Product Analytics on your GDK.
If !114501 (merged) has not yet been merged patch your package.json to update the version of @gitlab/ui
to 56.4.0
:
diff --git a/package.json b/package.json
index 4431bcde0cab..9f6a297c28e8 100644
--- a/package.json
+++ b/package.json
@@ -56,7 +56,7 @@
"@gitlab/favicon-overlay": "2.0.0",
"@gitlab/fonts": "^1.2.0",
"@gitlab/svgs": "3.24.0",
- "@gitlab/ui": "56.3.0",
+ "@gitlab/ui": "56.4.0",
"@gitlab/visual-review-tools": "1.7.3",
"@gitlab/web-ide": "0.0.1-dev-20230223005157",
"@mattiasbuelens/web-streams-adapter": "^0.1.0",
Run yarn
to install the latest dependancies and visit the dashboard page and verify that the charts display as expected.
http://localhost:3000/gitlab-org/gitlab-shell/-/product_analytics/dashboards/dashboard_behavior
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #393355 (closed)