Skip to content

Disable DDL transactions in 20230214181633 migration

Stan Hu requested to merge sh-disable-ddl-transaction-issue-396345 into master

What does this MR do and why?

If the batched background migration for CopyColumnUsingBackgroundMigrationJob were not completed before upgrading GitLab, the migration added in !111968 (merged) for GitLab 15.10 would fail with:

The `finalize_batched_background_migration` cannot be run inside a transaction. You can disable transactions by calling `disable_ddl_transaction!` in the body of your migration class.

We need to disable DDL transactions to make this work.

Relates to #396345 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports