Retry review apps jobs in all cases

David Dieulivolrequested to merge
ddieulivol-always_retry_review_deploy_on_failure into master

Context

Jobs failure like https://gitlab.com/gitlab-org/gitlab/-/jobs/3920941089 are dependent on third-party issues, and we cannot retry them directly.

Other examples are of failures that could benefit having a job retry are errors coming from https://gitlab.com/gitlab-org/quality/engineering-productivity-infrastructure/-/issues/53.

What does this MR do?

We not only retry the job under certain conditions, we retry review-app-related jobs every time they fail, as 99% of the failures are transient anyways.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports