Skip to content

Fix spec violations and refactor metric_chart_spec

Lorenz van Herwaarden requested to merge fix-spec-violations-metric-chart into master

What does this MR do and why?

In regards of epic &5102, this MR fixes the following spec violations in ee/spec/frontend/analytics/productivity_analytics/components/metric_chart_spec.js #391089 (closed):

  • spying on methods

In addition, I've also refactored some tests such that they Don't test the library, but rather what is rendered.

How to set up and validate locally

Run tests:

yarn jest ee/spec/frontend/analytics/productivity_analytics/components/metric_chart_spec.js

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #391089 (closed)

Merge request reports