Skip to content

Login.scss page bundle

Enrique Alcántara requested to merge 239847-login-page-bundle into master

What does this MR do and why?

It converts scss/pages/login.scss into a page bundle. login.scss contains two top class selectors:

  1. login-page
  2. devise-layout-html

I looked for all the files where these class selectors are used and I included the new page-specific stylesheet.

Screenshots or screen recordings

page Before After
admin login admin_login_before admin_login_after
login login_before login_after
sign up sign_up_before sign_up_after
welcome page welcome_before welcome_after
SAML login saml_before saml_after
SAML login with devise_empty.html.haml layout saml_devise_empty_before saml_devise_empty_after
Two factor authentication Screenshot_2023-03-21_at_10.20.37_AM Screenshot_2023-03-21_at_10.16.24_AM

How to set up and validate locally

We need to verify that all pages that use the login stylesheet still look good 😬. I’ll provide instructions to access these pages.

NOTICE: We are modifying layout templates in this Merge Request. If a page that uses one of these layout templates looks correct, the other pages that use the same layout template should also be correct.

Admin login

Go to Admin -> Settings -> General -> Sign-in restrictions -> And check "Enable admin mode"

Sign in / sign up pages

Sign out in your local GDK and open the Sign In and Registration pages

SAML login

Welcome page

  • Go to Admin -> Overview -> Users
  • Invite a new user and approve them
  • Sign in with the new user’s account.

Two-factor authentication

Set up two-factor authentication for the GDK user in https://gdk.test:3443/-/profile/two_factor_auth

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #239847 (closed)

Edited by Enrique Alcántara

Merge request reports