Skip to content

Hide edit for single user approval rules

Andrew Fontaine requested to merge afontaine/edit-protected-environment-approvers--hide-edit into master

What does this MR do and why?

Single user approval rules should be set to 1 always, as there is only 1 single user in the rule. How do you get 1 user to approve something twice?

We hide the edit button instead of disabling it so users don't think there should be a way to enable it that they are missing.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Enable the feature flag:
Feature.enable(:multiple_environment_approval_rules_fe)
  1. Navigate to a project's environments page Deployments > Environments
  2. Add an environment
  3. Navigate to the CI/CD settings page Settings > CI/CD
  4. Protect the environment with a single user approval rule
  5. expand environment block

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Andrew Fontaine

Merge request reports