Skip to content

Update menu item for analytics dashboards and update license checks

Robert Hunt requested to merge 388557-update-menu-item-to-point-to-shared-dashboards-listing into master

What does this MR do and why?

This MR continues the process of moving the product analytics dashboards across from /-/product_analytics/dashboards to /-/analytics/dashboards. There are several MRs which progressively move parts over to make it easier to review:

MR/Issue Purpose Status
Add new analytics dashboards listing route and ... (!112321 - merged) Create new route and view Merged
Create new analytics dashboards app (!112196 - merged) Move basic structure Merged
Add product analytics specific dashboards to sh... (!112298 - merged) Move product analytics specific dashboards and visualizations Merged
Move the visualization designer and rename from... (!113538 - merged) Move visualization designer and rename from panel designer Merged
Update menu item for analytics dashboards and u... (!114235 - merged) Update menu item to point to the shared dashboards listing 👈 You are here
Present call-to-actions to configure dashboards... (#388629 - closed) Add new onboarding flow for product analytics dashboards in the list Scheduled
Remove product analytics specific dashboard lis... (#390551 - closed) Remove old product analytics dashboards code Scheduled

This MR specifically:

  • Updates the existing menu item that is currently pointing to [PROJECT]/-/product_analytics/dashboards and points it to the new shared analytics dashboards listing at [PROJECT]/-/analytics/dashboards.
  • Adds licensing checks to the menu item and controller to make sure that we are applying the correct permissions to this new shared listing.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Check that the left-hand menu does not show the menu item
  2. Try visiting the dashboards listing and confirm that it 404's e.g. http://gdk.test:3000/gitlab-org/gitlab-test/-/analytics/dashboards
  3. Enable the feature flag: echo "Feature.enable(:combined_analytcs_dashboards)" | rails c
  4. Make sure you are using an EE licence
  5. Check the left-hand menu to see if the menu item is shown
  6. Check that clicking on the menu item opens the dashboards listing, and it doesn't 404

If you want to test the existence of product analytics specific dashboards on this listing you will need to:

  1. Make sure you are using an GitLab Ultimate licence
  2. Follow the instructions at https://gitlab.com/gitlab-org/gitlab/-/snippets/2474959 to enable product analytics on your GDK
  3. Try visiting the dashboards listing and confirm that it renders the product analytics built-in dashboards e.g. http://gdk.test:3000/gitlab-org/gitlab-test/-/analytics/dashboards

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #388557 (closed)

Edited by Robert Hunt

Merge request reports