Skip to content

Clean-up feature-flag git_abuse_rate_limit_feature_flag & keep code

Hinam Mehra requested to merge 394996-remove-ff-git-abuse-rate-limit into master

What does this MR do and why?

  1. Removes feature flag git_abuse_rate_limit_feature_flag and keeps the code.
  2. git_abuse_rate_limit_feature_flag was used to toggle the Git abuse rate limit settings in the Admin > Reporting page. The settings will now be displayed to all instance-level admins.

Screenshots or screen recordings

How to set up and validate locally

  1. Log-in as root and configure Git abuse rate limit settings on http://localhost:3000/admin/application_settings/reporting. Set
Number of repositories = 1
Reporting time period (seconds) = 300
Send notifications to - root
Toggle-on - Automatically ban users from this application when they exceed the specified limits
  1. Try to clone any two private repositories as another user. When cloning the second repository, you should receive a 403 error and the user should get banned.
  2. The admin can disable the setting by setting either Number of repositories or Reporting time period to 0.
  3. You can then try unbanning the user from http://localhost:3000/admin/users?filter=banned and cloning the repos again.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #394996 (closed)

Edited by Hinam Mehra

Merge request reports