Skip to content

Remove unused setModalData Vuex action on pipeline security tab

Daniel Tian requested to merge 390071-remove-is-resolved-for-finding-modal into master

What does this MR do and why?

In ee/app/assets/javascripts/vue_shared/security_reports/store/actions.js, there is a setModalData action that sets an isResolved property that's read in the finding modal (ee/app/assets/javascripts/vue_shared/security_reports/components/modal.vue). This confused me because a finding can only be dismissed or un-dismissed using the modal, but not set to resolved. After looking into it, I found out that the action is unused, so this MR removes the action and all uses of the isResolved property.

Note that there are calls to setModalData() in the code, but they use the action in ee/app/assets/javascripts/security_dashboard/store/modules/vulnerabilities/actions.js, not the one removed here.
ksnip_20230307-151721

How to set up and validate locally

  1. Clone a project with vulnerabilities: https://gitlab.com/gitlab-examples/security/security-reports
  2. Run a pipeline for the project.
  3. View the pipeline's security tab and click on a finding to show the finding modal.
  4. Verify the modal renders properly.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #390071 (closed)

Merge request reports