Skip to content

Refactor protected environments list UI

Andrew Fontaine requested to merge afontaine/edit-protected-environments--badges into master

What does this MR do and why?

GlAccordion doesn't allow for extra HTML in its header area, which we need to show the rules counts. There were also some inconsistencies between the designed UI and GlAccordion.

To save the footprint of the existing component, a new UI component was created to iterate over the list of environments and pass it back via a slot.

Screenshots or screen recordings

image

image

How to set up and validate locally

  1. Enable the feature flag:
Feature.enable(:multiple_environment_approval_rules_fe)
  1. Navigate to a project's environments page Deployments > Environments
  2. Add an environment
  3. Navigate to the CI/CD settings page Settings > CI/CD
  4. Protect the environment, with approvers

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports