Add runner registration feedback

What does this MR do and why?

This change adds feedback for the user to see when a runner registration has been successful.

Screenshots or screen recordings

See the entire demo at: https://youtu.be/6Bi8XsB73_M

How to set up and validate locally

1. Enable the feature flag: in your console rails c, and then Feature.enable(:create_runner_workflow_for_admin)
2. Use the main version of runner (note that this version has not been released)

$ cd ~
$ curl --output gitlab-runner https://gitlab-runner-downloads.s3.amazonaws.com/main/binaries/gitlab-runner-darwin-amd64
$ chmod +x gitlab-runner
$ ./gitlab-runner install

2. Follow the runner creation instructions from http://gdk.test:3000/admin/runners

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #383139 (closed)

changed milestone to %15.10

added GitLab Free Technical Writing UI text UX [Deprecated] Category:Runner Fleet devopsverify documentation featureaddition grouprunner sectionops severity3 typefeature workflowin dev + 1 deleted label

assigned to @mrincon

Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.

This message was generated automatically. You're welcome to improve it.

@gdoyle @pedropombeiro this is the branch I am using to test the complete workflow, by using this, you can verify the findings I posted at: gitlab-runner#29665 (closed)

added backend frontend labels

	2 Warnings
	featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart. For more information, see: The Handbook page on merge request types. The definition of done documentation.
	This merge request changed files with disabled eslint rules. Please consider fixing them.

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Disabled eslint rules

The following files have disabled eslint rules. Please consider fixing them:

• app/assets/javascripts/ci/runner/components/registration/platforms_drawer.vue

Run the following command for more details

node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
  'app/assets/javascripts/ci/runner/components/registration/platforms_drawer.vue'

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Miranda Fluharty (@mfluharty) (UTC-6, 7 hours behind @mrincon)	Phil Hughes (@iamphill) (UTC+0, 1 hour behind @mrincon)
UX	Gina Doyle (@gdoyle) (UTC-4, 5 hours behind @mrincon)	Maintainer review is optional for UX

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for 616a244c

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
| Manage           | 34     | 0      | 3       | 1     | 37    | ❗     |
| Govern           | 27     | 0      | 5       | 5     | 32    | ❗     |
| Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
| Verify           | 12     | 0      | 0       | 1     | 12    | ❗     |
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 163    | 0      | 12      | 7     | 175   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

mentioned in issue gitlab-runner#29665 (closed)

deleted the 383139-installation-drawer branch. This merge request now targets the master branch

added 1106 commits

• 69a04f98...22ed1f2d - 1105 commits from branch master
• 5dea9643 - Add runner registration feedback

Compare with previous version

changed the description

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 2656b8a6 and 616a244c

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.54 MB	3.54 MB	-	0.0 %
mainChunk	2.04 MB	2.04 MB	-	0.0 %

---

Note: We do not have exact data for 2656b8a6. So we have used data from: deed59e8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

added 36 commits

• 5dea9643...ad12c606 - 34 commits from branch master
• e0db0ddf - Add runner description to commands
• d3344318 - Add runner registration feedback

Compare with previous version

changed target branch from master to 383139-add-runner-description

added 1 commit

• 19d38aae - Add runner registration feedback

Compare with previous version

changed the description

added 1 commit

• a4bd447c - Add runner registration feedback

Compare with previous version

changed the description

@mnearents can you help me review the UX here? Thanks!

requested review from @mnearents

@gdoyle @DarrenEastman I am planning for this MR to be our MVC of the create_runner_workflow_for_admin feature that would potentially released widely.

Please help me review it in case you think there is anything we should add before we move ahead.

cc @pedropombeiro @nicolewilliams

deleted the 383139-add-runner-description branch. This merge request now targets the master branch

added 214 commits

• a4bd447c...8662ba56 - 213 commits from branch master
• aade84a3 - Add runner registration feedback

Compare with previous version

changed the description

added 1 commit

• 03b58b4d - Add runner registration feedback

Compare with previous version

@sdejonge can you help me review this frontend MR? Thanks!

requested review from @sdejonge

mentioned in merge request !114290 (merged)

mentioned in issue #383139 (closed)

approved this merge request

@mnearents, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label

removed review request for @mnearents

added 1 commit

• 616a244c - Address review suggestions

Compare with previous version

mentioned in merge request !114446 (merged)

@mrincon I just noticed that the term 'instance' runner is used at the start of the workflow, but I think it should be shared runner since that's the term we use now for these types of runners. I tried to find the exact copy location in the text but couldn't see it here to add a suggestion.

Button copy: New instance runner Copy on create page: 'Create an instance runner that generates a command...'

approved this merge request

requested review from @iamphill and removed review request for @sdejonge

approved this merge request

Approved, there is just !113557 (comment 1311978393) to solve I think?

removed review request for @iamphill

requested review from @iamphill

resolved all threads

enabled an automatic merge when the pipeline for 83036ac0 succeeds

merged

mentioned in commit 5eb19812

removed workflowin dev label

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

mentioned in issue #387882 (closed)