Add new eslint rule check
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR implements #392708 (closed) .
It adds a new eslint rule, that checks if afterEach
block of our jest tests contains any wrapper.destroy()
calls or wrapper = null
assignments, which are redundant now.
This MR has a lot of files changed, but fear not, as almost all of them are just spec files with eslint fix applied.
For better reviewing experience I suggest reviewing it on a commit basis.
- Adding the rule setup
- Applying a fix for the new rule
- Bringing back wrapper.destroy() for some of the specs
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
The change only affects linter setup.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Change any spec file containing wrapper.destroy()
calls. The linter should highlight this violation.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.