Skip to content

Fix product analytics JSON files formatting

Robert Hunt requested to merge fix-product-analytics-json-files-formatting into master

What does this MR do and why?

Whilst working on Replace product analytics dashboard listing wit... (#388557 - closed) it became apparent that the product analytics JSON files were out-of-sync with the latest JSON formatting guidelines.

In this MR I ran scripts/lint-json -f $(grep -rl . ee/app/assets/javascripts/product_analytics/dashboards/gl_dashboards) to correct this discrepancy and prevent pipeline failures within other MRs.

Screenshots or screen recordings

Listing Dashboard
image image

How to set up and validate locally

To test the product analytics dashboard items are shown, you will need to follow the instructions at https://gitlab.com/gitlab-org/gitlab/-/snippets/2474959 to enable Product Analytics on your GDK.

  1. Visit a projects product analytics dashboards listing e.g. http://gdk.test:3000/gitlab-org/gitlab-test/-/product_analytics/dashboards
  2. Validate that the page is rendered with a list of product analytics dashboards
  3. Click on different dashboards and validate that the dashboard is shown

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Robert Hunt

Merge request reports