Merged message: change alignment of revert and cherry-pick buttons
What does this MR do and why?
Moves the Merged message buttons (revert / cherry-pick) to the right to align with other actions from other widgets.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Open a merged MR in GDK (e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/8)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added UX UX Paper Cuts featureenhancement frontend sectiondev severity4 typefeature + 1 deleted label
assigned to @seggenberger
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
1 Warning ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Paul Gascou-Vaillancourt (
@pgascouvaillancourt
) (UTC-5, 6 hours behind@seggenberger
)Simon Knox (
@psimyn
) (UTC+11, 10 hours ahead of@seggenberger
)UX Julia Miocene (
@jmiocene
) (UTC+1, same timezone as@seggenberger
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Danger- Resolved by Phil Hughes
Hey @philipjoyce seems like roulette likes to select you for my reviews
👋 Can you have a quick look at this UX change?🙇
requested review from @philipjoyce
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2ae502b1 and 19bcfb3f
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.5 MB 3.5 MB - 0.0 % mainChunk 2 MB 2 MB - 0.0 %
Note: We do not have exact data for 2ae502b1. So we have used data from: 43531bd8.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
❗ test report for 19bcfb3fexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Manage | 34 | 0 | 3 | 1 | 37 | ❗ | | Govern | 27 | 0 | 5 | 5 | 32 | ❗ | | Verify | 12 | 0 | 0 | 1 | 12 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 163 | 0 | 12 | 7 | 175 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
removed review request for @philipjoyce
👋 @philipjoyce
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
Hey @pgascouvaillancourt can you do the frontend review? TY!
requested review from @pgascouvaillancourt
added maintenanceusability label
added typemaintenance label and removed featureenhancement typefeature labels
- Resolved by Sascha Eggenberger
- Resolved by Phil Hughes
Thanks for the fix @seggenberger
👍 I left a couple thoughts for you to consider. Back to you for now.removed review request for @pgascouvaillancourt
added 1 commit
- 19bcfb3f - Merged message: change alignment of revert and cherry-pick buttons
requested review from @iamphill
Hey @iamphill can you have a look at this change to make sure we don't break other things? Thank you in advance!
🙇 Edited by Sascha EggenbergerLGTM @seggenberger
💯 changed milestone to %15.10
enabled an automatic merge when the pipeline for 8e80fde7 succeeds
mentioned in commit af82e6de
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1990 (merged)
mentioned in issue #368083 (closed)
mentioned in merge request gitlab-com/www-gitlab-com!122231 (merged)