Skip to content
Snippets Groups Projects

Merged message: change alignment of revert and cherry-pick buttons

Merged Sascha Eggenberger requested to merge merged-message-buttons-alignment into master
All threads resolved!

What does this MR do and why?

Moves the Merged message buttons (revert / cherry-pick) to the right to align with other actions from other widgets.

Screenshots or screen recordings

Before After
before after
before2 after2

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Open a merged MR in GDK (e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/8)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks for the fix @seggenberger 👍 I left a couple thoughts for you to consider. Back to you for now.

  • removed review request for @pgascouvaillancourt

  • added 1 commit

    • 19bcfb3f - Merged message: change alignment of revert and cherry-pick buttons

    Compare with previous version

  • Sascha Eggenberger requested review from @iamphill

    requested review from @iamphill

  • Hey @iamphill can you have a look at this change to make sure we don't break other things? Thank you in advance! 🙇

    cc @pgascouvaillancourt

    Edited by Sascha Eggenberger
  • Paul Gascou-Vaillancourt approved this merge request

    approved this merge request

  • changed milestone to %15.10

  • Phil Hughes approved this merge request

    approved this merge request

  • Phil Hughes resolved all threads

    resolved all threads

  • Phil Hughes enabled an automatic merge when the pipeline for 8e80fde7 succeeds

    enabled an automatic merge when the pipeline for 8e80fde7 succeeds

  • merged

  • Phil Hughes mentioned in commit af82e6de

    mentioned in commit af82e6de

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #368083 (closed)

  • Please register or sign in to reply
    Loading