Skip to content

Open vulnerability history comment editor on focus

Lorenz van Herwaarden requested to merge history-comment-focus into master

What does this MR do and why?

Similar to editing normal comments on an MR, for the vulnerability report details comments, when focusing on the "Add a comment" field (it's a button) by tabbing, it should show the editor. Before, it only showed the editor when clicking.

Screenshots or screen recordings

history-comment-focus

Focusing and clicking shows editor now.

How to set up and validate locally

You'll need an EE license

  1. Import security-reports project
  2. Run pipeline on master branch
  3. Go to vulnerability report page and select a vulnerability
  4. Change status of vulnerability with dropdown in top right
  5. En entry in the discussion at the bottom is added
  6. Validate that by pressing the tab button (until it reaches the "Add a comment" field of that entry), it enables the comment editor and allows you to immediately type the comment
  7. Click cancel for that comment editor
  8. Validate that clicking the "Add a comment" field also still enables the comment editor

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #393055 (closed)

Edited by Lorenz van Herwaarden

Merge request reports