Skip to content

Code quality card use new prop titleIconClass

Lixin Wan requested to merge gitlab-jh/jh-team/gitlab:feat/code-quality-card-use-new-props into master

What does this MR do and why?

In this MR !108648 (merged) , we propose a follow-up action of adding props to gl-single-stat in the GitLab UI, which would allow for the addition of color to titleIcon. As of now, GitLab UI has implemented the props titleIconClass gitlab-ui!3304 (merged) and GitLab has upgraded the GitLab UI version in this MR !112998 (merged).

This MR is being used to remove the custom styling on gl-single-stat and utilize the new prop titleIconClass at project quality card.

Previous MR: !108648 (merged)

/cc @JeremyWuuuuu @mtan-gitlab @rob.hunt

Screenshots or screen recordings

image

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Open project quality tab (open feature flag) : Feature.enable(:project_quality_summary_page)
  2. Config code quality scan in project CI, and run it.
  3. After running, it will be displayed in project -> Analytics -> CI/CD -> project quality

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lixin Wan

Merge request reports