Skip to content

Update super sidebar counter styles to have 32px height

Scott de Jonge requested to merge 393131-counter-height-32px into master

What does this MR do and why?

Update super sidebar counter styles to have 32px height

  • Add temp gl-inset-border-1-gray-a-08 class to super_sidebar.scss
  • Add line-height:normal to <counter>
  • Add box-shadow: none on :hover/:focus

Screenshots or screen recordings

Before After
gitlab.com_gitlab-org_gitlab_-_issues_393131 127.0.0.1_3000_dashboard_todos
gitlab.com_gitlab-org_gitlab_-issues_393131__1 127.0.0.1_3000_dashboard_todos__1_

How to set up and validate locally

  • Enable the feature flag in rails console with rails c
Feature.enable(:super_sidebar_nav)
  • Enable the "New navigation" setting toggle from the user dropdown

CleanShot_2023-01-24_at_17.50.44_2x

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #393131 (closed)

Merge request reports