Skip to content
Snippets Groups Projects

GraphQL: Add membership filter to ProjectRunnersResolver

Closed Tymm Schmitke requested to merge tschmitke/383510/add_enum_to_resolver into master

What does this MR do and why?

This MR aims to close #383510.

Screenshots or screen recordings

How to set up and validate locally

  1. Visit http://gdk.test:3000/-/graphql-explorer
  2. Use this query, and change the membership param.
query projectFinder {
  projects {
    edges {
      node {
        id
        runners(membership: PARENT_GROUPS) {
          count
        }
      }
    }
  }
}
  1. Notice the count of runners changes with different membership params.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 3 Warnings
    074b09b5: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
    712b98af: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
    d96d6e45: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    3 Messages
    📖 CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    📖 This merge request adds or changes files that require a review from the Database team.
    📖 This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

    1. Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
    2. Prepare your MR for database review according to the docs.
    3. Assign and mention the database reviewer suggested by Reviewer Roulette.

    The following files require a review from the Database team:

    • app/finders/ci/runners_finder.rb

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Thomas Hutterer current availability (@thutterer) (UTC+1, 6 hours ahead of @tschmitke) Kassio Borges current availability (@kassio) (UTC+0, 5 hours ahead of @tschmitke)
    database Dmitry Gruzd current availability (@dgruzd) (UTC+1, 6 hours ahead of @tschmitke) Pavel Shutsin current availability (@pshutsin) (UTC+1, 6 hours ahead of @tschmitke)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the 🔁 danger-review job that generated this comment.

    Generated by 🚫 Danger

  • Tymm Schmitke added 1 commit

    added 1 commit

    • a15bb0ea - Add membership to runners_finder_params

    Compare with previous version

  • Pedro Pombeiro
  • Pedro Pombeiro
  • Tymm Schmitke added 1 commit

    added 1 commit

    Compare with previous version

  • Tymm Schmitke added 1 commit

    added 1 commit

    Compare with previous version

  • Tymm Schmitke added 1 commit

    added 1 commit

    • ad369d4f - Use subgroup for parent_groups spec

    Compare with previous version

  • Tymm Schmitke marked this merge request as ready

    marked this merge request as ready

  • Tymm Schmitke changed the description

    changed the description

  • Tymm Schmitke requested review from @pedropombeiro

    requested review from @pedropombeiro

  • Pedro Pombeiro changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading