Skip to content
Snippets Groups Projects

Add notification when retrying trigger job

Merged Frédéric Caplette requested to merge 391877-frontend-add-toast-notification into master
All threads resolved!

What does this MR do and why?

Behind the FF ci_recreate_downstream_pipeline, we allow use to retry their trigger jobs. This has the effect of spawning an new downstream pipeline. There are instances where while the new pipeline is getting created, the old one is no longer visible in the graph. For the MVC of this feature, showing a simple toast message that explains that a downstream pipeline might not yet be visible while being recreated.

Screenshots or screen recordings

Before after
Screenshot_2023-02-23_at_10.31.02_AM Screenshot_2023-02-23_at_10.31.11_AM

Video of the new behaviour

Screen_Recording_2023-02-23_at_9.43.04_AM

How to set up and validate locally

  1. Turn on ci_recreate_downstream_pipeline FF through rails console.
  2. Setup your GDK to have working runners https://docs.gitlab.com/runner/configuration/macos_setup.html
  3. Write a CI/CD configuration with at least one downstream pipeline. Given that you have another repository (let's call it my-other-project) and that your username is root, something like this will work (Also make sure that the other project also has a functioning runner.):
trigger_job1:
  stage: build
  trigger: 'root/my-other-project'
  1. Run a pipeline in the main project and wait for it to finish
  2. Notice that the trigger job can be retried
  3. Click on the retry button
  4. Confirm that you want to retry the job
  5. Notice the toast message appears

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #391877 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in issue #387972 (closed)

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits ef596da1 and 8231b214

    Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.49 MB 3.49 MB - 0.0 %
    mainChunk 2 MB 2 MB - 0.0 %

    Note: We do not have exact data for ef596da1. So we have used data from: 5a02f654.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by 🚫 Danger

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: test report for 8231b214

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Govern           | 27     | 0      | 5       | 5     | 32    | ❗     |
    | Manage           | 34     | 0      | 3       | 0     | 37    | ✅     |
    | Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Verify           | 10     | 2      | 0       | 1     | 12    | ❌     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 161    | 2      | 12      | 6     | 175   | ❌     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Marcel Amirault removed review request for @marcel.amirault

    removed review request for @marcel.amirault

  • added 1 commit

    Compare with previous version

  • requested review from @marcel.amirault

  • requested review from @dstull and @katiemacoy

  • Doug Stull approved this merge request

    approved this merge request

  • 👋 @dstull, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Doug Stull removed review request for @dstull

    removed review request for @dstull

  • added 1 commit

    Compare with previous version

  • requested review from @aturinske

  • Marcel Amirault approved this merge request

    approved this merge request

  • Marcel Amirault removed review request for @marcel.amirault

    removed review request for @marcel.amirault

  • added 1 commit

    Compare with previous version

  • Katie Macoy approved this merge request

    approved this merge request

  • Katie Macoy removed review request for @katiemacoy

    removed review request for @katiemacoy

  • Alexander Turinske approved this merge request

    approved this merge request

  • Alexander Turinske resolved all threads

    resolved all threads

  • Alexander Turinske enabled an automatic merge when the pipeline for 4390e610 succeeds

    enabled an automatic merge when the pipeline for 4390e610 succeeds

  • mentioned in commit cfe47c0c

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #367547 (closed)

  • Please register or sign in to reply
    Loading