Add notification when retrying trigger job
What does this MR do and why?
Behind the FF ci_recreate_downstream_pipeline
, we allow use to retry their trigger jobs. This has the effect of spawning an new downstream pipeline. There are instances where while the new pipeline is getting created, the old one is no longer visible in the graph. For the MVC of this feature, showing a simple toast message that explains that a downstream pipeline might not yet be visible while being recreated.
Screenshots or screen recordings
Before | after |
---|---|
![]() |
![]() |
Video of the new behaviour
Screen_Recording_2023-02-23_at_9.43.04_AM
How to set up and validate locally
- Turn on
ci_recreate_downstream_pipeline
FF through rails console. - Setup your GDK to have working runners https://docs.gitlab.com/runner/configuration/macos_setup.html
- Write a CI/CD configuration with at least one downstream pipeline. Given that you have another repository (let's call it
my-other-project
) and that your username isroot
, something like this will work (Also make sure that the other project also has a functioning runner.):
trigger_job1:
stage: build
trigger: 'root/my-other-project'
- Run a pipeline in the main project and wait for it to finish
- Notice that the trigger job can be retried
- Click on the retry button
- Confirm that you want to retry the job
- Notice the toast message appears
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #391877 (closed)
Merge request reports
Activity
changed milestone to %15.10
added ~29105604 Technical Writing UI text UX devopsverify frontend grouppipeline authoring sectionops severity4 typefeature workflowplanning breakdown + 1 deleted label
assigned to @f_caplette
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
- Resolved by Alexander Turinske
Before this goes into review @sunjungp and @marcel.amirault, could you take a look at the copy? I went with:
Downstream pipeline could disappear while the new one is being created
, WDYT?
3 Warnings ⚠ 8231b214: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ⚠ 246afefa: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Doug Stull (
@dstull
) (UTC-5, same timezone as@f_caplette
)Alexander Turinske (
@aturinske
) (UTC+11, 16 hours ahead of@f_caplette
)UX Katie Macoy (
@katiemacoy
) (UTC+13, 18 hours ahead of@f_caplette
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Dangerrequested review from @marcel.amirault
added featureenhancement label
- Resolved by Frédéric Caplette
mentioned in issue #387972 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ef596da1 and 8231b214
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.49 MB 3.49 MB - 0.0 % mainChunk 2 MB 2 MB - 0.0 %
Note: We do not have exact data for ef596da1. So we have used data from: 5a02f654.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
❌ test report for 8231b214expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Govern | 27 | 0 | 5 | 5 | 32 | ❗ | | Manage | 34 | 0 | 3 | 0 | 37 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Framework sanity | 9 | 0 | 1 | 0 | 10 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 10 | 2 | 0 | 1 | 12 | ❌ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 161 | 2 | 12 | 6 | 175 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Alexander Turinske
removed review request for @marcel.amirault
requested review from @marcel.amirault
- Resolved by Alexander Turinske
@katiemacoy Could you do the UX review here?
🙏🏻 @dstull could you do the initial frontend review? Thanks!
requested review from @dstull and @katiemacoy
👋 @dstull
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @dstull
requested review from @aturinske
- Resolved by Frédéric Caplette
removed review request for @marcel.amirault
removed review request for @katiemacoy
enabled an automatic merge when the pipeline for 4390e610 succeeds
mentioned in commit cfe47c0c
added workflowstaging-canary label and removed workflowplanning breakdown label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
mentioned in issue #367547 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label