Remove Jira Connect public key storage config
What does this MR do and why?
This removes the jira_connect.enable_public_keys_storage
config. It was replaced by the jira_connect_public_key_storage_enabled
application setting in !110640 (merged). The config was still around to make sure the new application setting is enabled on GitLab.com. This is now the case (gitlab-com/gl-infra/production#8392 (closed)) so we can continue removing the config.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #391330 (closed)
Merge request reports
Activity
changed milestone to %15.9
assigned to @Andysoiron
changed milestone to %15.10
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tianwen Chen (
@tianwenchen
) (UTC+11, 10 hours ahead of@Andysoiron
)Allen Cook (
@acook.gitlab
) (UTC-5, 6 hours behind@Andysoiron
)~"group::integrations" (backend) Bojan Marjanović (
@bmarjanovic
) (UTC+1, same timezone as@Andysoiron
)Maintainer review is optional for ~"group::integrations" (backend) To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Allen Cook
Hey @bmarjanovic, can do you do the initial review?
requested review from @bmarjanovic
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for b55f70bbexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 31 | 0 | 5 | 0 | 36 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 31 | 0 | 5 | 0 | 36 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for b55f70bbexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 379 | 0 | 31 | 3 | 410 | ❗ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 16 | 0 | 27 | 0 | 43 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Verify | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 420 | 0 | 60 | 3 | 480 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
requested review from @acook.gitlab and removed review request for @bmarjanovic
@bmarjanovic
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit 88cbcefe
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1990 (merged)
added groupimport and integrate label and removed groupintegrations [DEPRECATED] label
mentioned in issue bmarjanovic/growth-and-development#1