Skip to content

Introduce registry_size_estimated to namespace_root_storage_statistics

Mohamed Hamda requested to merge add-estimated-to-namespace_root_storage_statistics into master

What does this MR do and why?

Relates to: #385390 (closed)

This Merge Request adds support for a new feature being introduced by the Container Registry API. The new feature will provide an indicator that informs users whether the deduplicated size for a namespace is an estimated value or not. In order to support this feature, the GitLab Rails app needs to make some updates.

In summary, this Merge Request adds a new database column to store the registry_size_estimated boolean and updates the GraphQL schema to expose this column to the frontend

Notes:

  • Adding with_lock_retries as namespace_root_storage_statistics is a large table
  • Adding an index since refreshing of estimated container registry might introduce querying this column very often
  • Assumption: A default value of false would be appropriate, as it indicates that the value is not estimated by default.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vasilii Iakliushin

Merge request reports