Fix Code Quality text contrast
What does this MR do and why?
Fixes Text color for Code Quality findings in MRs is ... (#388822 - closed)
Screenshots or screen recordings
| Code Highlight Theme | Before | After |
|---|---|---|
| Dark |  |
 |
| Light |  |
 |
How to set up and validate locally
- Open any merge request that has at least one change
- Apply the following patch:
codequality.patch
Index: app/assets/javascripts/diffs/components/diff_view.vue
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/assets/javascripts/diffs/components/diff_view.vue b/app/assets/javascripts/diffs/components/diff_view.vue
--- a/app/assets/javascripts/diffs/components/diff_view.vue (revision c0b73e5f5a9162d775f0809ae7f638a2f57bfb93)
+++ b/app/assets/javascripts/diffs/components/diff_view.vue (date 1676994736371)
@@ -266,6 +266,7 @@
/>
<diff-line
v-if="
+ true ||
glFeatures.refactorCodeQualityInlineFindings &&
codeQualityExpandedLines.includes(getCodeQualityLine(line))
"
Index: app/assets/javascripts/diffs/components/diff_code_quality.vue
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/assets/javascripts/diffs/components/diff_code_quality.vue b/app/assets/javascripts/diffs/components/diff_code_quality.vue
--- a/app/assets/javascripts/diffs/components/diff_code_quality.vue (revision c0b73e5f5a9162d775f0809ae7f638a2f57bfb93)
+++ b/app/assets/javascripts/diffs/components/diff_code_quality.vue (date 1676994736374)
@@ -38,7 +38,7 @@
</h4>
<ul class="gl-list-style-none gl-mb-0 gl-p-0">
<li
- v-for="finding in codeQuality"
+ v-for="finding in [{ severity: 'major', description: 'foobar' }]"
:key="finding.description"
class="gl-pt-1 gl-pb-1 gl-font-regular gl-display-flex"
>MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.