Skip to content

Draft: Rename .with_feedback_type to .by_feedback_type

mo khan requested to merge 387238/pipeline_security_report_finding_type into master

What does this MR do and why?

While investigating an N+1 query I noticed the definition of .with_feedback_type is defined as a class method when a Rails scope is the canonical way to define this. I also chose to rename the scope from .with_ to .by_ as we tend to use .with_ prefixes for scopes that preload or include additional associations and .by_ prefixes for scopes that are used to filter via WHERE clauses.

#387238 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by mo khan

Merge request reports