Draft: Rename .with_feedback_type to .by_feedback_type
What does this MR do and why?
While investigating an N+1 query I noticed the definition of
.with_feedback_type
is defined as a class method when a Rails scope is
the canonical way to define this. I also chose to rename the scope from .with_
to .by_
as we tend to use .with_
prefixes for scopes that preload or include
additional associations and .by_
prefixes for scopes that are used to filter
via WHERE
clauses.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by mo khan