Skip to content

Restyles the search button in the new nav

Sam Beckham requested to merge search-button-styling into master

What does this MR do and why?

This MR updates the temporary button in the new navigation to better match the design system, especially in dark mode. See the before / after screenshots for more context.

It also turns the button into a link for global search as it's a more usable experience until we get the search modal implemented in [MVC] - Search modal (#378542 - closed)

Screenshots or screen recordings

Before After
Dark nav_search_before_1 nav_search_after_1
Dark (hover) nav_search_before_1 nav_search_after_2
Light nav_search_before_2 nav_search_after_4
Light (hover) nav_search_before_2 nav_search_after_3

How to set up and validate locally

  1. Enable the feature flag:
echo "Feature.enable(:super_sidebar_nav)" | rails c
  1. Enable the user setting from the user dropdown:

Screenshot_2022-12-13_at_1.32.43_PM

  1. The super sidebar should now appear on every page.
  2. Search is in the top right corner of the navigation sidebar

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sam Beckham

Merge request reports