Skip to content

Pass the correct container object for DORA metrics

Adam Hegyi requested to merge 384551-fix-vsa-dora-metrics-classes into master

What does this MR do and why?

This MR fixes the missing DORA metrics from the project-level VSA page.

Problem: we've recently removed the project-level CycleAnalytics::ProjectStage model and replaced it with CycleAnalytics::Stage. The model has a parent method which always points to a namespace record.

  • Before the change: stage.parent -> Project or Group
  • After the change: stage.parent -> Namespaces::ProjectNamespace or Group

The DORA service accepts Project or a Group as the container. When an instance of Namespaces::ProjectNamespace was passed in, the service started to fail.

Why did it happen? We didn't have a test case covering the case for a Namespaces::ProjectNamespace object. Also, the service was always stubbed out.

How to set up and validate locally

  1. Ensure that you have Ultimate license
  2. Go to Project > Analytics > Value Stream
  3. The DORA metrics tiles should show up (lead time for changes, change failure rate, etc.)

image

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #384551 (closed)

Edited by Adam Hegyi

Merge request reports