Skip to content

Update yml validation to be more clear

Briley Sandlin requested to merge 362453-validation-segment into master

What does this MR do and why?

Resolves #362453 (closed)

We want to update the pipeline editor validator to be more clear. In the case of a circular include, we now provide a link to the troubleshooting documentation. More info can be found in the issue.

All other validation variants should remain the same for this component. Needed to refactor the file in order to support any inline links.

Screenshots or screen recordings

before after
ci_validation_before ci_validation_after

How to set up and validate locally

  1. Create a new project cicd-circular
  2. Create a file file1.yml:
include:
  - file2.yml
  1. Create a file file2.yml:
include:
  - file1.yml
  1. Create a file .gitlab-ci.yml:
include:
  - file1.yml
  1. Go to CI/CD Editor. Note after a period of time the message "Configuration validation currently not available." is displayed.
  2. Go to Repository, Files, click on .gitlab-ci.yml and then click on Edit. Make a minor change and click Commit Changes. After a period, the error is displayed.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Briley Sandlin

Merge request reports