Skip to content

Make detecting HTML block comments stricter

Brett Walker requested to merge bw-fix-task-summary-timeout into master

What does this MR do and why?

Related to 500 Timeout while viewing issue or merge reques... (#391390 - closed) and Tasks count checkboxes in commented sections (#270947 - closed)

Regex for detecting HTML comments was too aggressive and caused timeouts when scanning for checklist items.

Make the comment block syntax stricter, and add in detection of html line comment, otherwise the could get false positives for block comments.

How to set up and validate locally

  1. Copy the markdown in the file markdown.md
  2. Paste it into a new issue
  3. The issue should save quickly. You should see 15 of 26 checklist items completed at the top of the issue
  4. Go to the issue list, it should show the list normally, without timeout.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Brett Walker

Merge request reports