Use correct favicon for wait for resource status
What does this MR do and why?
The current favicon does not exist and causes this warnings on production:
Kibana logs |
---|
![]() |
DEPRECATION WARNING: The asset "ci_favicons/favicon_pending.png" is not present in the asset pipeline. Falling back to an asset that may be in the public folder. This behavior is deprecated and will be removed. To bypass the asset pipeline and preserve this behavior, use the
skip_pipeline: true option. (called from status_overlay at /srv/gitlab/lib/gitlab/favicon.rb:33)
Contributes to &7875 (closed).
How to verify locally
❌
Before $ bin/rspec spec/features/projects/jobs_spec.rb -e 'when job is waiting for resource'
Run options: include {:full_description=>/when\ job\ is\ waiting\ for\ resource/}
Randomized with seed 20549
Test environment set up in 7.29151438 seconds
Jobs
GET /:project/jobs/:id
when job is waiting for resource
Starting the Capybara driver server...
Capybara starting Puma...
* Version 5.6.5 , codename: Birdie's Version
* Min threads: 0, max threads: 4
* Listening on unix:///tmp/20230210-1097393-frhc8u
DEPRECATION WARNING: The asset "ci_favicons/favicon_pending.png" is not present in the asset pipeline.
Falling back to an asset that may be in the public folder.
This behavior is deprecated and will be removed.
To bypass the asset pipeline and preserve this behavior,
use the `skip_pipeline: true` option.
(called from status_overlay at /home/peter/devel/gitlab/gdk/gitlab/lib/gitlab/favicon.rb:33)
DEPRECATION WARNING: The asset "ci_favicons/favicon_pending.png" is not present in the asset pipeline.
Falling back to an asset that may be in the public folder.
This behavior is deprecated and will be removed.
To bypass the asset pipeline and preserve this behavior,
use the `skip_pipeline: true` option.
(called from status_overlay at /home/peter/devel/gitlab/gdk/gitlab/lib/gitlab/favicon.rb:33)
shows correct UI components
Finished in 22.49 seconds (files took 22.66 seconds to load)
1 example, 0 failures
Randomized with seed 20549
[TEST PROF INFO] Time spent in factories: 00:01.350 (3.62% of total time)
✅
After $ bin/rspec spec/features/projects/jobs_spec.rb -e 'when job is waiting for resou
rce'
Run options: include {:full_description=>/when\ job\ is\ waiting\ for\ resource/}
Randomized with seed 14380
Test environment set up in 5.38358783 seconds
Jobs
GET /:project/jobs/:id
when job is waiting for resource
Starting the Capybara driver server...
Capybara starting Puma...
* Version 5.6.5 , codename: Birdie's Version
* Min threads: 0, max threads: 4
* Listening on unix:///tmp/20230210-1098882-3wbe26
shows correct UI components
Finished in 19 seconds (files took 9.94 seconds to load)
1 example, 0 failures
Randomized with seed 14380
[TEST PROF INFO] Time spent in factories: 00:01.788 (8.62% of total time)
The deprecation warning is gone
DEPRECATION WARNING: The asset "ci_favicons/favicon_pending.png" is not present in the asset pipeline.
Falling back to an asset that may be in the public folder.
This behavior is deprecated and will be removed.
To bypass the asset pipeline and preserve this behavior,
use the `skip_pipeline: true` option.
(called from status_overlay at /home/peter/devel/gitlab/gdk/gitlab/lib/gitlab/favicon.rb:33)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Thong Kuah