Skip to content

Move onboarding to only happen for groups created during registration

Doug Stull requested to merge 388970-learn-gitlab-should-no-longer-be-created-as-its-own-project-ob into master

What does this MR do and why?

What

  • Moves group onboarding to only happen during group creation that happens during new user registration.
  • Resolves rubocop issues with files touched.
  • Adjusts the query count exception during registration process to add in 2 more queries. I'm not exactly sure why this increased as it is the same process in registration as before. Perhaps since onboarding was in a transaction loop that affected the query count before and now it isn't.
  • Refactors a bit of the feature specs around this change to DRY them up just a bit more.

Why

The intention of onboarding was for it to only be created during a user's registration when they created a group during that process. This MR will make sure that is true. Before this MR a group was always onboarded during the group creation process.

See #388970 (closed), specifically this thread

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #388970 (closed)

Edited by Doug Stull

Merge request reports