Skip to content

Fix error when modal is unmounted during delete

What does this MR do and why?

Before deleting runners, we confirm this action via a modal.

This fix ensures the modal is always mounted, even after runners are deleted, so the modal can be hidden correctly.

Changelog: fixed

Screenshots or screen recordings

Before

2023-02-09_12.23.54

After

2023-02-09_12.23.28

How to set up and validate locally

Open your browser console to see the issue.

  1. Visit the admin area
  2. Selecte CI/CD -> Runners, e.g. http://gdk.test:3000/admin/runners?runner_type[]=PROJECT_TYPE
  3. Select a few runners with the checkboxes on the left
  4. Delete them
  5. Check the there are no errors

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #391204 (closed)

Merge request reports