Skip to content

Add feature category to Ci::JobTokenScope::RemoveProjectService spec

drew stachon requested to merge add-pe-category-to-graphql-spec into master

What does this MR do and why?

This MR adds a feature category to a service class spec that doesn't currently have one. I'm currently working on it, and it's definitely part of the Category:Continuous Integration work.

How to set up and validate locally

The standard unlabeled-spec warnings go away on my feature change here:

$ git checkout master
$ bundle exec rspec spec/services/ci/job_token_scope/remove_project_service_spec.rb
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Test environment set up in 5.146572 seconds
Missing metadata feature_category: ./spec/support/shared_examples/ci/edit_job_token_scope_shared_examples.rb:5 See https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#feature-category-metadata
.Missing metadata feature_category: ./spec/support/shared_examples/ci/edit_job_token_scope_shared_examples.rb:5 See https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#feature-category-metadata
.Missing metadata feature_category: ./spec/support/shared_examples/ci/edit_job_token_scope_shared_examples.rb:5 See https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#feature-category-metadata
.Missing metadata feature_category: ./spec/services/ci/job_token_scope/remove_project_service_spec.rb:18 See https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#feature-category-metadata
.Missing metadata feature_category: ./spec/services/ci/job_token_scope/remove_project_service_spec.rb:18 See https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#feature-category-metadata
.Missing metadata feature_category: ./spec/support/shared_examples/ci/edit_job_token_scope_shared_examples.rb:5 See https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#feature-category-metadata
.

Finished in 8.54 seconds (files took 10.86 seconds to load)
6 examples, 0 failures
$ git fetch origin add-pe-category-to-graphql-spec
$ git checkout origin/add-pe-category-to-graphql-spec
$ bundle exec rspec spec/services/ci/job_token_scope/remove_project_service_spec.rb
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Test environment set up in 4.669678 seconds
......

Finished in 7.13 seconds (files took 9.89 seconds to load)
6 examples, 0 failures

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports