Skip to content

Upgrade gitlab-styles to 10.0.0

Omar Qunsul requested to merge upgrade-gitlab-styles-to-10-0-0 into master

What does this MR do and why?

Upgrade gitlab-styles to 10.0.0.

Changelog

https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/tags/v10.0.0

Checklist

  • Upgrade released version of gitlab-styles
    • Make sure release is complete
    • Rephrase the title and MR description to match final upgrade
    • Point to released version in Gemfile
      • gem 'gitlab-styles', '~> 9.1.0', require: false
      • Update bundler's checksum file via bundle exec bundler-checksum init
    • (Optional) Regenerate TODOs for new/changed cop rules
    • Make sure CI passes 💚
    • Let the MR being reviewed again and merged
    • (Optional) Refine this MR template.

New offenses

   1561 Lint/SymbolConversion
    887 Layout/EmptyLineAfterMagicComment
    500 Lint/EmptyBlock
    304 Naming/InclusiveLanguage
    292 Lint/AmbiguousOperatorPrecedence
    114 Style/NumberedParameters
     81 Lint/NonAtomicFileOperation
     38 Lint/DuplicateBranch
     25 Layout/ArgumentAlignment
     21 Lint/NoReturnInBeginEndBlocks
     13 Lint/RedundantDirGlobSort
      8 Style/RedundantRegexpEscape
      7 GitlabSecurity/PublicSend
      6 Lint/AmbiguousRange
      5 Security/CompoundHash
      4 Performance/StringInclude
      4 Lint/OrAssignmentToConstant
      3 Lint/ToEnumArguments
      3 Lint/DuplicateRegexpCharacterClassElement
      2 RSpec/ContextMethod
      2 Lint/UnexpectedBlockArity
      2 Lint/TripleQuotes
      2 Lint/DeprecatedConstants
      2 Cop/RedirectWithStatus
      1 Style/ZeroLengthPredicate
      1 RSpec/MissingFeatureCategory
      1 Lint/UnmodifiedReduceAccumulator
      1 Lint/IncompatibleIoSelectWithFiberScheduler
      1 Lint/EmptyClass
      1 Layout/SpaceInsidePercentLiteralDelimiters
      1 Layout/LineLength

TODOs regenerated

bin/rake rubocop:todo:generate[Cop/GemFetcher,Cop/RedirectWithStatus,GitlabSecurity/PublicSend,Layout/ArgumentAlignmen
t,Layout/EmptyLineAfterMagicComment,Layout/LineLength,Layout/SpaceInsidePercentLiteralDelimiters,Lint/AmbiguousOper
atorPrecedence,Lint/AmbiguousRange,Lint/DeprecatedConstants,Lint/DuplicateBranch,Lint/DuplicateRegexpCharacterClass
Element,Lint/EmptyBlock,Lint/EmptyClass,Lint/IncompatibleIoSelectWithFiberScheduler,Lint/NonAtomicFileOperation,Lin
t/NoReturnInBeginEndBlocks,Lint/OrAssignmentToConstant,Lint/RedundantDirGlobSort,Lint/SymbolConversion,Lint/ToEnumA
rguments,Lint/TripleQuotes,Lint/UnexpectedBlockArity,Lint/UnmodifiedReduceAccumulator,Naming/InclusiveLanguage,Perf
ormance/StringInclude,RSpec/ContextMethod,RSpec/MissingFeatureCategory,Security/CompoundHash,Style/NumberedParameters,Style/RedundantRegexpEscape,Style/ZeroLengthPredicate]

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports