Improve devise error_message
What does this MR do and why?
As a first iteration of #384351, this MR improves error messages UI by using Pajamas Alert component.
done:
- Add
devise/shared/error_messages
in the project, instead of using the one fromdevise
gems : https://github.com/heartcombo/devise/blob/main/app/views/devise/shared/_error_messages.html.erb - Convert the
erb
tohaml
- Use
Pajamas::AlertComponent.new
instead of pure HTML list
This change will affect:
- app/views/devise/confirmations/new.html.haml
- app/views/devise/passwords/edit.html.haml
- app/views/devise/passwords/new.html.haml
- app/views/devise/registrations/edit.html.erb
- app/views/devise/shared/_signup_box.html.haml
- app/views/devise/unlocks/new.html.haml
- app/views/registrations/welcome/show.html.haml
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Navigate to signup form
http://localhost:3000/users/sign_up
- use an already use email address, like
scotty.satterfield@whiteschaefer.biz
in GDK - press Register
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #384351
Edited by Laurent Deketelaere