Skip to content

Trim trailing insignificant zeros from VSD values

Ezekiel Kigbo requested to merge 384350-drop-least-significant-zero into master

What does this MR do and why?

Follow up MR to !110055 (merged)

  • Updates VSD formatting to remove extra trailing Zeros
  • Adds new jest tests
  • Updates existing formatting methods

Screenshots or screen recordings

Before After
Screenshot_2023-02-08_at_5.22.41_pm Screenshot_2023-02-08_at_5.22.11_pm

How to set up and validate locally

  • Seed cycle analytics data
  • Create an environment from the UI named production
  • Open the rails console
    $ rails c
  • Seed DORA daily metrics in the environment using the new environment
    // Within the rails console
    $ e = Environment.order(:id)[-1]
    $ 100.times { |i| Dora::DailyMetrics.create(environment_id: e.id, date: (i + 1).days.ago, deployment_frequency: rand(50), incidents_count: rand(5), lead_time_for_changes_in_seconds: rand(50000), time_to_restore_service_in_seconds: rand(100000)) }
  • Enable the Exec dashboard
    Feature.enable(:group_analytics_dashboards_page)
  • Visit the exec dashboard: http://gdk.test:3000/groups/${YOUR_GROUP}/-/analytics/dashboards

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #384350 (closed)

Edited by Ezekiel Kigbo

Merge request reports