Skip to content

Clarify DeploymentApprovals checkbox wording

Manuel Grabowski requested to merge mg-clarifydeploymentapprovalswording-20230206 into master

What does this MR do and why?

See discussion in #381418 (comment 1206854951) – the wording of this checkbox is currently not clearly explaining what it actually does.

This checkbox enables changed behavior in two aspects:

  • Pipeline triggerers can now approve their own deployments
  • Deployments where the triggerer is allowed to approve them will automatically be approved

The current wording is confusing, because the title of the checkbox only mentions the first part, whereas the help text only mentions the second part.

Screenshots or screen recordings

Note: This screenshot was faked by using Web inspector. I did not test this locally.

image

How to set up and validate locally

Note: I did not test this – it is a simple string replacement, and I do not know if this is how this is supposed to be done.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports