Fix Flaky spec/controllers/projects/pipelines_controller_spec.rb
requested to merge 345470-spec-failure-in-spec-controllers-projects-pipelines_controller_spec-rb-projects into master
What does this MR do and why?
Moving flaky spec to request instead of controller
Controller specs should not be used to write N+1 tests as the controller is only initialized once per example. This could lead to false successes where subsequent “requests” could have queries reduced (for example, because of memoization).
Screenshots or screen recordings
N/A
How to set up and validate locally
Running spec locally should not fail
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #345470 (closed)
Edited by Max Fan