Skip to content

Stop creating AuthorizedProjectUpdate::UserRefreshFromReplicaWorker jobs

Manoj M J requested to merge mmj-skip-safety-net-workers into master

What does this MR do and why?

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/381884

Context

We enqueue AuthorizedProjectUpdate::UserRefreshFromReplicaWorker jobs across the app, in many different places, as a safety-net job to refresh project authorizations.

These safety nets have been there for a very long time now, and in self-managed instances instances without enough Sidekiq fire power, this could cause trouble, especially because of the fact that a large majority of self-managed instances do not have replica databases set up, so even the safety-net jobs use primary database, thus increasing the load on the primary. (On gitlab.com, safety net jobs run on the replica db)

We remove safety nets entirely, first by putting it behind a feature flag, and running it for a couple of milestones. If there aren't grave errors, we are safe to remove them entirely.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Manoj M J

Merge request reports