Check out to (/workspace/)gitlab-development-kit/gitlab

Ash McKenzierequested to merge
ashmckenzie/gitpod-experiment into master

What does this MR do and why?

This MR changes the location where Gitpod clones https://gitlab.com/gitlab-org/gitlab from /workspace/gitlab to /workspace/gitlab-development-kit/gitlab. Currently, checking out the code to /workspace/gitlab does work but we need to create a symlink from /workspace/gitlab-development-kit/gitlab that points /workspace/gitlab but results in gdk <any-command>'s failing when sitting in the /workspace/gitlab directory because the gdk command line has no way to reverse look through directories to determine if we're sitting under a GDK install.

Current master

  1. Create a new Gitpod instance using the master branch by clicking https://gitpod.io/#https://gitlab.com/gitlab-org/gitlab/-/tree/master/
  2. Click the 'New Terminal' button towards the bottom right-hand corner of the screen - image
  3. Notice the current working directory is /workspace/gitlab
  4. Type in: 
    gdk status
  5. You should see the following error message: 
    
The current working directory is not inside a gitlab-development-kit
installation. Use 'cd' to go to your gitlab-development-kit.

# Default: /tmp/gitlab-development-kit

Using ashmckenzie/gitpod-experiment branch

  1. Create a new Gitpod instance using the ashmckenzie/gitpod-experiment branch by clicking https://gitpod.io/#https://gitlab.com/gitlab-org/gitlab/-/tree/ashmckenzie/gitpod-experiment/
  2. Click the 'New Terminal' button towards the bottom right-hand corner of the screen - image
  3. Notice the current working directory is /workspace/gitlab-development-kit/gitlab
  4. Type in: 
    gdk status
  5. You should see the following successful output (actual pid and timings will vary): 
    run: /workspace/gitlab-development-kit/services/gitlab-workhorse: (pid 83788) 274s, normally down; run: log: (pid 82034) 283s
run: /workspace/gitlab-development-kit/services/postgresql: (pid 82044) 283s, normally down; run: log: (pid 82039) 283s
run: /workspace/gitlab-development-kit/services/praefect: (pid 82504) 281s, normally down; run: log: (pid 82035) 283s
run: /workspace/gitlab-development-kit/services/praefect-gitaly-0: (pid 82505) 281s, normally down; run: log: (pid 82042) 283s
run: /workspace/gitlab-development-kit/services/rails-background-jobs: (pid 83789) 274s, normally down; run: log: (pid 82036) 283s
run: /workspace/gitlab-development-kit/services/rails-web: (pid 83790) 274s, normally down; run: log: (pid 82037) 283s
run: /workspace/gitlab-development-kit/services/redis: (pid 82045) 283s, normally down; run: log: (pid 82038) 283s
run: /workspace/gitlab-development-kit/services/sshd: (pid 83791) 274s, normally down; run: log: (pid 82040) 283s
run: /workspace/gitlab-development-kit/services/webpack: (pid 83792) 274s, normally down; run: log: (pid 82041) 283s

=> GitLab available at http://127.0.0.1:3000.
=>   - Ruby: ruby 3.0.5p211 (2022-11-24 revision ba5cf0f7c5) [x86_64-linux].
=>   - Node.js: v16.15.0.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports