Draft: Use a modal to confirm triggering prune
requested to merge 31354-cleaned-commits-can-still-be-accessed-after-running-repository-cleanup-ux into 31354-cleaned-commits-can-still-be-accessed-after-running-repository-cleanup
What does this MR do and why?
This is mean to address the feedback from !105584 (merged)
- Do we need a dedicated section for
Pruning unreachable objects? Could it be combined with the housekeeping section eg. below
- This is a non-reversible destructive action. I think we should consider showing a modal and prompt people to confirm before they proceed as per guidelines. WDYT?
Screenshots or screen recordings
Clicking the Prune unreachable objects button should open this modal:
How to set up and validate locally
- Settings -> General
- Scroll down to Advanced and click expand
- See a button for
Prune unreachable objects - Click the button and see a modal
- Click ok and validate that a request is made to housekeeping with prune=true and get redirected to the project page
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #31354 (closed)
Edited by Jerry Seto