Skip to content

Migrate ide_edit metrics to instrumentation class

What does this MR do and why?

action_monthly_active_users_ide_edit metric wan't migrated to instrumentation class, this MR fixes it.

Unblocks !110834 (merged) by removing dependancy on events_for_category

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

> author = User.first
> project = Project.first
> Gitlab::UsageDataCounters::EditorUniqueCounter.track_web_ide_edit_action(author: author, project: project)
> Gitlab::UsageDataCounters::EditorUniqueCounter.track_sfe_edit_action(author: author, project: project)
> Gitlab::UsageDataCounters::EditorUniqueCounter.track_snippet_editor_edit_action(author: author, project: project)
# check that values arent included in old `UsageData` report
> Gitlab::UsageData.data[:usage_activity_by_stage_monthly][:create][:action_monthly_active_users_ide_edit]
=> nil
# But generated but ServicePing report (using instrumentation class)
> Gitlab::Usage::ServicePingReport.for(output: :all_metrics_values)[:usage_activity_by_stage_monthly][:create][:action_monthly_active_users_ide_edit]
=> 1

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #387786 (closed)

Edited by Niko Belokolodov

Merge request reports