gitaly: Remove readiness check
What does this MR do and why?
The Gitaly readiness check is invoked by a GitLab Rails readiness check
endpoint GET /-/readiness?all=1 and the gitlab:gitaly:check rake
task. The ReadinessCheck RPC, as currently implemented, is not fit for
use by the Rails API as it was originally intended as a diagnostic tool
and not something to be invoked frequently. The checks in the RPC open
multiple database pools and run heavy queries, which can consume
significant quantities of system resources. The rake task also has an
inherent issue with this RPC because the task calls Praefect through the
load balancer. This means that results could vary depending on which
Praefect node recieves the request.
To avoid these problems, this change removes the invocation of the
ReadnessCheck RPC. Future updates to this RPC will allow for the check
to be reintroduced.
Resolves gitaly#4751 (closed) and #390155 (closed) and #389996 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.