Skip to content
Snippets Groups Projects

Document invalid metadata deletions being default enabled

Merged Sami Hiltunen requested to merge smh-default-enable-verifier into master
All threads resolved!

What does this MR do?

Praefect has default enabled invalid metadata deletion. Document this fact.

Related issues

gitaly#4429 (comment 1257330331)
gitaly#4429 (closed)

Author's checklist

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

  • ~"frontend"
  • ~"backend"
  • ~"type::bug"
  • ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • Ensure a release milestone is set.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • John Cai
  • thanks for this update @samihiltunen! had a couple of suggestions for your consideration, but nothing blocking.

  • John Cai approved this merge request

    approved this merge request

  • Sami Hiltunen added 2 commits

    added 2 commits

    • ce138d7f - Add migration instructions for Praefect's new configuration
    • 5205168d - Document invalid metadata deletions being default enabled

    Compare with previous version

  • Sami Hiltunen added 3 commits

    added 3 commits

    • f53f5017 - Update documentation to match Praefect's new configuration structure
    • 4e2b9002 - Add migration instructions for Praefect's new configuration
    • bc85b67d - Document invalid metadata deletions being default enabled

    Compare with previous version

  • Evan Read removed review request for @eread

    removed review request for @eread

  • Sami Hiltunen added 1 commit

    added 1 commit

    • f79ebfc0 - Document invalid metadata deletions being default enabled

    Compare with previous version

  • @eread This should also be ready to go along with !110379 (merged)

  • Sami Hiltunen added 1882 commits

    added 1882 commits

    Compare with previous version

  • Toon Claes approved this merge request

    approved this merge request

  • !110379 (merged) was merged, and proper approvals were given. Merging.

  • Toon Claes resolved all threads

    resolved all threads

  • Toon Claes enabled an automatic merge when the pipeline for 1335dea2 succeeds

    enabled an automatic merge when the pipeline for 1335dea2 succeeds

  • merged

  • Toon Claes mentioned in commit 15b151dc

    mentioned in commit 15b151dc

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading