Skip to content

Fix false positives for approved by insufficient users violation

Huzaifa Iftikhar requested to merge 389840_fix_false_positive_in_compliance_violation into master

What does this MR do and why?

Approved by insufficient users compliance violation requires at least two users to approve a merge request. Instead of counting the number of users who approved the merge request, we were counting the eligible approvers for the merge request which resulted in false positive compliance violations being created.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create a project.
  2. Create a merge request (MR) inside that project.
  3. Approve the MR by two users (other than the MR author)
  4. Merge the MR.
  5. Verify that "Less than 2 approvers" violation is not created. (This violation is created on master currently despite having two approvals)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #389840 (closed)

Edited by Huzaifa Iftikhar

Merge request reports