Skip to content

Update breadcrumbs at Admin Area > Messages > Edit

Daniel Schömer requested to merge quatauta/gitlab-contrib:389480-admin-area-messages-edit-broadcrumb-messages-links-to-edited-message into master

What does this MR do and why?

In the GitLab Admin Area / Messages, when editing an existing message, the breadcrumb at the top of the page displays "Admin Area > Messages".

Breadcrumb "Messages" indicates to have a link to the list of messages (.../admin/broadcast_messages). But Breadcrumb "Messages" has a link to the current page (editing the message, .../admin/broadcast_messages/1/edit).

There is no breadcrumb displayed to indicate a link to the current page, editing a message.

This MR updates the breadcrumbs:

  • Change breadcrumb "Messages" to link to the list of messages (.../admin/broadcast_messages)
  • Add breadcrumb "Message" with a link to the current page (.../admin/broadcast_messages/1/edit)

Screenshots or screen recordings

(When taking the screenshots, I was editing message number 2 😞 )

Current pre-MR screenshot: Breadcrumb "Messages" links to the current page editing the message (http://127.0.0.1:3000/admin/broadcast_messages/1/edit):

pre-commit

Post-merge screenshots:

  1. Breadcrumb "Messages" links to the message list (http://127.0.0.1:3000/admin/broadcast_messages)
  2. Additional breadcrumb "Messages" links to the current page editing the message (http://127.0.0.1:3000/admin/broadcast_messages/1/edit)

post-commit-1 post-commit-2

How to set up and validate locally

  1. Start GitLab and open GitLab (locally with the GitLab Development Kit (GDK), or online with GitPod)
  2. Login with a GitLab admin user
  3. Open Admin Area / Messages (http://127.0.0.1:3000/admin/broadcast_messages/ for a locally running GitLab)
  4. Create and save a new broadcast message "Test message" (the text or other message settings you enter do not matter)
  5. Edit the broadcast message (via the pencil icon in the lower left, http://127.0.0.1:3000/admin/broadcast_messages/1/edit)
  6. In the broadcast message edit page, the breadcrumbs between the GitLab search field and the message display says "Admin Area > Messages"

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #389480 (closed)

Edited by Daniel Schömer

Merge request reports