Skip to content

Resolve "User can create on-call rotation with negative length"

What does this MR do and why?

Added validation for rotationLength form field.

Screenshots or screen recordings

context before after
adding rotation create_rotation_with_negative_length_before create_rotation_with_negative_length_after
editing rotation edit_rotation_with_negative_length_before edit_rotation_with_negative_length_after

How to set up and validate locally

Prerequisite:

  • This is a premium feature
  • You must have at least the Maintainer role.

To open create an on-call schedule modal:

  1. On the top bar, select Main menu > Projects and find your project.
  2. On the left sidebar, select Monitor > On-call Schedules.
  3. Select Add a schedule.
  4. Enter the schedule’s name and description and select a time zone.
  5. In the rotation section of your schedule, click Add rotation
  6. To edit, click the edit button on a specific rotation on your on-call timeline

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #332474 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports