Skip to content

Improve Monitor empty states for people without permissions

Marcin Sedlak-Jakubowski requested to merge msj-esc-pol-empty-state into master

What does this MR do and why?

Improve the empty state for escalation policies to be consistent with the one in on-call schedules and show additional text to users without the required permissions.

Inject urls to project members sorted by permissions for both escalation policies and on-call schedules.

See #338919 (comment 1252885220) for the goal texts.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

permissions Escalation policies (before) Escalation policies (after)
owner before_with_permissions after_with_permissions
reporter before_no_permissions after_no_permissions

How to set up and validate locally

  1. Log in to GDK.
  2. Make sure you have no on-call schedules and escalation policies, to be able to see empty states.
  3. If logged in as admin, go to http://localhost:3000/flightjs/Flight/-/project_members and choose a user with Reporter role. Go to http://localhost:3000/admin/users/[paste_chosen_username] and click Impersonate.
  4. Go to http://127.0.0.1:3001/flightjs/Flight/-/escalation_policies

Escalation policies requirements

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Paulina Sedlak-Jakubowska

Merge request reports