Skip to content

Adding integration private key field type

Darby Frey requested to merge app-store-key-file-type into master

What does this MR do and why?

As a follow-up to !108626 (closed), this MR uses the dropzone component to provide an easier, and more secure mechanism for uploading private key files.

This MR adds a new integrations component called upload_dropzone, which wraps the existing dropzone Vue component that already exists and adds some basic configuration so it can tie into the integrations components.

The screenshot below shows what it looks like in the integration setup UI as the App store private key input.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Enable the Apple App Store integration feature flag in the rails console 
    Feature.enable(:apple_app_store_integration)
  2. Visit the Apple App Store integration page for a project http://localhost:3001/flightjs/Flight/-/settings/integrations/apple_app_store/edit
  3. Only .p8 file types are allowed. The dropzone will allow any text file with a .p8 extension, so it fine to create a dummy file locally to test.
  4. If a allowed filetype is selected the input will change to the name of the file. If a not allowed file is selected, and error message will be displayed.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Darby Frey

Merge request reports