Skip to content

Resolve "Alert activity feed is broken"

What does this MR do and why?

I wasn't able to find a direct cause of the bug. I tried to compare this timeline to the one in incidents and merge requests, but they're all a bit differently constructed. I ended up adding position: relative to a icon container. And that seems to be enough to ensure the proper stacking context - the vertical line gets under the icon now.

Screenshots or screen recordings

before after
alert_timeline_icons_before alert_timeline_icons_after

How to set up and validate locally

To see alerts, you need to send a test alert. Here's how to do that:

  1. Navigate to Settings > Monitor
  2. Expand the Alert section, and click the button to "Enable a new integration"
  3. Select "HTTP endpoint" in the integration type dropdown. Add an integration name, turn the toggle to "active", and click to "Save the integration"
  4. Once the integration is added, click on the settings icon button in the integration table
  5. Click on the "Send test alert" tab
  6. Enter the sample payload shown below, and click send.
  7. Navigate to Monitor > Alerts, where you will see the new alert appear. This issue is visible in the "Activity feed" tab

{ "title": "Gitaly latency is too high", "description": "https://gitlab.com/gitlab-com/runbooks/-/blob/master/docs/gitaly/gitaly-latency.md", "service": "service not affected", "monitoring_tool": "GitLab scripts", "severity": "high", "host": "fe-2" }

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #383131 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports